[PATCH] D80520: [yaml2obj] - Map section names to chunks for each ELFYAML::ProgramHeader early. NFCI.

[George Rimar via Phabricator via llvm-commits]

grimar marked 2 inline comments as done.
grimar added inline comments.


================
Comment at: llvm/include/llvm/ObjectYAML/ELFYAML.h:503-506
+  std::vector<SectionName> Sections;
+
+  // This vector is parallel to Sections and contains corresponding chunks.
+  std::vector<Chunk *> Chunks;
----------------
jhenderson wrote:
> Up to you, but maybe:
> ```
>   Optional<llvm::yaml::Hex64> Offset;
> 
>   std::vector<SectionName> Sections;
>   // This vector is parallel to Sections and contains corresponding chunks.
>   std::vector<Chunk *> Chunks;
> ```
OK.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80520/new/

https://reviews.llvm.org/D80520