[PATCH] D80285: [mlir] make the bitwidth of device side index computations configurable

Tue May 26 00:30:20 PDT 2020

herhut accepted this revision.
herhut added a comment.
This revision is now accepted and ready to land.

In D80285#2046233 <https://reviews.llvm.org/D80285#2046233>, @gysit wrote:

> My assumption is that the LLVMTypeConverterCustomization do not interfere with the address space conversion. Should the address space conversion be an integral part of the LLVMTypeConverterCustomization class?

This is a bit muddled at the moment but it is ok to assume this for now.

================
Comment at: mlir/lib/Conversion/GPUToNVVM/LowerGpuOpsToNVVMOps.cpp:109

+    /// Customize the bidtwidth used for the device side index computations
+    LLVMTypeConverterCustomization customs;
----------------
Typo: `bidtwidth` -> `bitwidth`

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80285/new/

https://reviews.llvm.org/D80285