[PATCH] D80020: [PowerPC] Add support for -mcpu=pwr10 in both clang and llvm

Nemanja Ivanovic via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon May 25 21:57:05 PDT 2020


nemanjai accepted this revision.
nemanjai added a comment.
This revision is now accepted and ready to land.

LGTM aside from a couple of minor nits.



================
Comment at: clang/lib/Basic/Targets/PPC.cpp:319
                         .Case("ppc64le", true)
+                        .Case("pwr10", true)
                         .Case("pwr9", true)
----------------
Please remove this since HTM was removed in P10.


================
Comment at: clang/test/Preprocessor/init-ppc64.c:644
+// PPCPOWER10:#define _ARCH_PWR7 1
+// PPCPOWER10:#define _ARCH_PWR9 1
+//
----------------
I am not sure what the story is with not checking for `_ARCH_PWR8` for the P9 test, but I don't think we need to continue that precedent.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80020/new/

https://reviews.llvm.org/D80020





More information about the llvm-commits mailing list