[PATCH] D80516: [ConstantFolding] Constant folding for integer vector reduce intrinsics

Eli Friedman via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon May 25 19:49:31 PDT 2020


efriedma added a comment.

Do we need to explicitly handle an undef vector here?



================
Comment at: llvm/lib/Analysis/ConstantFolding.cpp:1659
+    return nullptr;
+  FixedVectorType *VT = cast<FixedVectorType>(Op->getType());
+  if (!isa<ConstantInt>(Op->getAggregateElement(0U)))
----------------
Please use dyn_cast<> where appropriate.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80516/new/

https://reviews.llvm.org/D80516





More information about the llvm-commits mailing list