[PATCH] D80529: [DDG] Data Dependence Graph - Add query function for memory dependencies between two nodes

[Whitney Tsang via Phabricator via llvm-commits]

Whitney added inline comments.


================
Comment at: llvm/unittests/Analysis/DDGTest.cpp:82
+      " }\n"
+      "!llvm.module.flags = !{!0}\n"
+      "!llvm.ident = !{!1}\n"
----------------
line 82 - 89 needed?


================
Comment at: llvm/unittests/Analysis/DDGTest.cpp:101
+      assert(Header->getName() == "for.body");
+      Loop *L = LI.getLoopFor(Header);
+      EXPECT_NE(L, nullptr);
----------------
`LI.front()` should give you the first loop in a function.


================
Comment at: llvm/unittests/Analysis/DDGTest.cpp:102
+      Loop *L = LI.getLoopFor(Header);
+      EXPECT_NE(L, nullptr);
+
----------------
should this be an assert instead?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80529/new/

https://reviews.llvm.org/D80529