[PATCH] D78938: Fixing all comparisons for C++20 compilation.
Barry Revzin via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon May 25 13:56:10 PDT 2020
BRevzin added inline comments.
================
Comment at: llvm/include/llvm/ADT/DirectedGraph.h:97
+ }
+ friend bool operator!=(const NodeType &M, const NodeType &N) { !(M == N); }
----------------
jfb wrote:
> davidstone wrote:
> > Missing `return`
> 😱
>
> Did this not trigger a diagnostic when building? I wonder if it's just not on?
Yeah I was surprised too. I'm compiling with `-Wall -Wextra`...
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D78938/new/
https://reviews.llvm.org/D78938
More information about the llvm-commits
mailing list