[PATCH] D80511: [llvm-objcopy][ELF] Fix removing ".group" sections.

[Fangrui Song via Phabricator via llvm-commits]

MaskRay added a comment.

The code looks good. We have another issue: https://bugs.llvm.org/show_bug.cgi?id=46064 (if a member is deleted, SHT_GROUP content needs a change)

GNU objcopy was fixed by https://sourceware.org/git/?p=binutils-gdb.git;a=commit;h=30288845d67c64d07905c1e4ca9de4768d3b2dd8



================
Comment at: llvm/test/tools/llvm-objcopy/ELF/remove-group-section.test:1
+# RUN: yaml2obj %s -o - \
+# RUN:   | llvm-objcopy -R .group - - \
----------------
I'd prefer remove-section-group.test because the operation is `remove-section`.

(SHT_GROUP is referred to as "section group")


================
Comment at: llvm/test/tools/llvm-objcopy/ELF/remove-group-section.test:29
+
+# CHECK: Sections [
+# CHECK:   Section {
----------------
`Sections [` this line can be deleted


================
Comment at: llvm/test/tools/llvm-objcopy/ELF/remove-group-section.test:31
+# CHECK:   Section {
+# CHECK:     Name: .foo
+# CHECK-NEXT:     Type: SHT_PROGBITS
----------------
Indent keys. See other files for examples


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80511/new/

https://reviews.llvm.org/D80511