[PATCH] D80002: [yaml2obj] - Implement the "SectionHeaderTable" tag.

[Fangrui Song via Phabricator via llvm-commits]

MaskRay added inline comments.


================
Comment at: llvm/lib/ObjectYAML/ELFEmitter.cpp:343
+  else
+    Header.e_shnum = Doc.SectionHeader->Sections.size() + /*Null section*/ 1;
+
----------------
jhenderson wrote:
> I'm wondering whether we should make the null section explicit in the `SectionHeaderTable` block. This allows us to omit that section header entirely, or to have just a section header table containing only the null shdr.
Making the SHT_NULL section explicit in `SectionHeaderTable` seems fine, but how do we encode it?

The SHT_NULL section in `Sections` remains on-demand implicit.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80002/new/

https://reviews.llvm.org/D80002