[PATCH] D78107: [CSInfo][MIPS] Call delay slot support in DwarfDebug

[Nikola Tesic via Phabricator via llvm-commits]

ntesic marked 5 inline comments as done.
ntesic added a comment.





================
Comment at: llvm/lib/CodeGen/AsmPrinter/DwarfDebug.cpp:893
+      // Check if delay slot support is enabled.
+      if (!delaySlotSupported(*&MI))
         return;
----------------
dstenb wrote:
> I think this might read a bit as that we expect a delay slot instruction here. Could we perhaps break out the `hasDelaySlot()` check to here:
> 
> ```
> if (MI.hasDelaySlot() && !delaySlotSupported(*&MI))
>   return;
> ```
> 
> or perhaps instead rename the `delaySlotSupported()` function to indicate this (I don't have any better suggestion).
I agree, it seems more intuitive. Thanks for the suggestion.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78107/new/

https://reviews.llvm.org/D78107