[PATCH] D80307: [mlir] Add a shape op that always returns a successful witness
Stephan Herhut via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon May 25 04:46:31 PDT 2020
herhut accepted this revision.
herhut added a comment.
Thanks!
================
Comment at: mlir/include/mlir/Dialect/Shape/IR/ShapeOps.td:502
+// TODO: Support witness attributes and then make this ConstantLike.
+// Note: This operation might be replaced with a general op that takes a
----------------
jpienaar wrote:
> I'd be +1 this for consistency. If we have a witness attribute then I think we could just use std.const too.
>
> (then little helper function to check isTrueWitness(Operation* op), which we could add already)
I like the `isTrueWitness` to hide how this is implemented. Then we can move this to ConstantLike later without changing users.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D80307/new/
https://reviews.llvm.org/D80307
More information about the llvm-commits
mailing list