[PATCH] D80377: [flang] Google test infrastructure support for unittests

Kiran Chandramohan via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun May 24 16:31:32 PDT 2020


kiranchandramohan accepted this revision.
kiranchandramohan added a comment.
This revision is now accepted and ready to land.

Thanks @sameeranjoshi for working on this.

check-flang-unit works for me with ninja on Ubuntu Linux on AArch64 in-tree build.

Please wait for @tskeith to approve.



================
Comment at: flang/CMakeLists.txt:132
          "Generate build targets for the Flang unit tests."
-         ${LLVM_INCLUDE_TESTS})
+         ON)
   set(FLANG_BINARY_DIR ${CMAKE_BINARY_DIR}/tools/flang)
----------------
1) Does this mean that the flang unit tests cannot be controlled using LLVM_INCLUDE_TESTS?
2) Do you know why Clang/LLVM has unittests set to OFF by default?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80377/new/

https://reviews.llvm.org/D80377





More information about the llvm-commits mailing list