[PATCH] D80485: [DAGCombiner][PowerPC][AArch64] Remove isMulhCheaperThanMulShift TLI hook. Use isOperationLegal directly instead.

Sanjay Patel via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun May 24 10:08:38 PDT 2020


spatel added inline comments.


================
Comment at: llvm/lib/CodeGen/SelectionDAG/DAGCombiner.cpp:4121
   // plus a shift.
-  if (!TLI.isMulhCheaperThanMulShift(VT) && VT.isSimple() && !VT.isVector()) {
+  if (!TLI.isOperationLegal(ISD::MULHS, VT)  && VT.isSimple() && !VT.isVector()) {
     MVT Simple = VT.getSimpleVT();
----------------
Does it cause trouble to use isOperationLegalOrCustom(ISD::MULHS, VT)?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80485/new/

https://reviews.llvm.org/D80485





More information about the llvm-commits mailing list