[PATCH] D80484: [mlir][ods] Add simple generator for return types
Jacques Pienaar via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Sat May 23 15:55:11 PDT 2020
jpienaar created this revision.
jpienaar added a reviewer: mehdi_amini.
Herald added subscribers: llvm-commits, jurahul, Kayjukh, frgossen, grosul1, Joonsoo, stephenneuendorffer, liufengdb, aartbik, lucyrfox, mgester, arpith-jacob, nicolasvasilache, antiagainst, shauheen, rriddle.
Herald added a reviewer: antiagainst.
Herald added a reviewer: silvas.
Herald added a project: LLVM.
Take advantage of equality constrains to generate the type inference interface.
This is used for equality and trivially built types. The type inference method
is only generated when no type inference trait is specified already. Avoids the
need for custom build methods for simple cases that have been increasing. More
work needed to consolidate more, but simplifies the specification and can
iterate implementation side post.
This reorders verification that changes some test error messages (two verifications that overlap and the original verification isn't reached to be triggered).
Repository:
rG LLVM Github Monorepo
https://reviews.llvm.org/D80484
Files:
mlir/include/mlir/Dialect/Shape/IR/ShapeOps.td
mlir/include/mlir/TableGen/Attribute.h
mlir/include/mlir/TableGen/Operator.h
mlir/lib/Dialect/Shape/IR/Shape.cpp
mlir/lib/TableGen/Attribute.cpp
mlir/lib/TableGen/Operator.cpp
mlir/test/lib/Dialect/Test/TestOps.td
mlir/test/mlir-tblgen/op-decl.td
mlir/test/mlir-tblgen/types.mlir
mlir/tools/mlir-tblgen/OpDefinitionsGen.cpp
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D80484.265897.patch
Type: text/x-patch
Size: 23646 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200523/d13995fc/attachment-0001.bin>
More information about the llvm-commits
mailing list