[PATCH] D80276: [Alignment] Fix misaligned interleaved loads

Eli Friedman via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sat May 23 15:55:10 PDT 2020


efriedma added a comment.

> If I rerun the script on the test in trunk, the bad alignments get added. Was this pass original producing alignment of 0 and then changed to have this bug?

I expect that the testcases originally had zero alignment, and and we propagated that zero alignment, and therefore appeared to do something sane. With my recent changes, we now fix up the alignment in IR parsing, and therefore propagate the alignment as an actual number.  (This is why I suggested the testcases should be regenerated and committed separately, so it's clear what this patch is actually changing.)

Either way, the underlying bug isn't new. In practice, the alignment would never be zero at the point in a normal pass pipeline, even before my recent changes.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80276/new/

https://reviews.llvm.org/D80276





More information about the llvm-commits mailing list