[PATCH] D80478: [X86][AVX] Call SimplifyDemandedBits on MaskedLoadSDNode with non-boolean masks

Craig Topper via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sat May 23 14:51:22 PDT 2020


craig.topper added inline comments.


================
Comment at: llvm/lib/Target/X86/X86ISelLowering.cpp:42933
   // TODO: Expanding load with constant mask may be optimized as well.
-  if (Mld->isExpandingLoad())
-    return SDValue();
-
-  if (Mld->getExtensionType() == ISD::NON_EXTLOAD) {
+  if (!Mld->isExpandingLoad() && Mld->getExtensionType() == ISD::NON_EXTLOAD) {
     if (SDValue ScalarLoad = reduceMaskedLoadToScalarLoad(Mld, DAG, DCI))
----------------
Do we ever have expanding loads with non-i1 masks?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80478/new/

https://reviews.llvm.org/D80478





More information about the llvm-commits mailing list