[PATCH] D80476: [DebugInfo/llvm-objdump] - Print "ZERO terminator" for terminator entries when dumping .eh_frame.

[Fangrui Song via Phabricator via llvm-commits]

MaskRay added inline comments.


================
Comment at: llvm/lib/DebugInfo/DWARF/DWARFDebugFrame.cpp:307
 void CIE::dump(raw_ostream &OS, const MCRegisterInfo *MRI, bool IsEH) const {
+  // A CIE with a zero length is a terminator entry in the .eh_frame sextion.
+  if (IsEH && Length == 0) {
----------------
typo: section


================
Comment at: llvm/lib/DebugInfo/DWARF/DWARFDebugFrame.cpp:308
+  // A CIE with a zero length is a terminator entry in the .eh_frame sextion.
+  if (IsEH && Length == 0) {
+    OS << format("%08" PRIx64, Offset) << " ZERO terminator\n";
----------------
`binutils-gdb/binutils/dwarf.c:display_debug_frames` displays `ZERO terminator` for both `.eh_frame` and `.debug_frame`. We can be consistent here.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80476/new/

https://reviews.llvm.org/D80476