[PATCH] D80473: [LoopUtils] Qulify std::find
Whitney Tsang via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Sat May 23 10:03:30 PDT 2020
Whitney added inline comments.
================
Comment at: llvm/lib/Transforms/Utils/LoopUtils.cpp:716
if (Loop *ParentLoop = L->getParentLoop()) {
- Loop::iterator I = find(ParentLoop->begin(), ParentLoop->end(), L);
+ Loop::iterator I = std::find(ParentLoop->begin(), ParentLoop->end(), L);
assert(I != ParentLoop->end() && "Couldn't find loop");
----------------
How about change to `Loop::iterator I = find(ParentLoop, L)`?
================
Comment at: llvm/lib/Transforms/Utils/LoopUtils.cpp:720
} else {
- Loop::iterator I = find(LI->begin(), LI->end(), L);
+ Loop::iterator I = std::find(LI->begin(), LI->end(), L);
assert(I != LI->end() && "Couldn't find loop");
----------------
How about change to `Loop::iterator I = find(LI, L);`
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D80473/new/
https://reviews.llvm.org/D80473
More information about the llvm-commits
mailing list