[PATCH] D80203: [ObjectYAML][DWARF] Add DWARF entry in ELFYAML.

[Xing GUO via Phabricator via llvm-commits]

Higuoxing updated this revision to Diff 265844.
Higuoxing added a comment.

Addressed comments:

[ObjectYAML]

- Support adjusting section offset via `YAMLSec->Offset`
- Replace `llvm_unreachable` by `reportError()` and add one testcase (i) for it.
- Thanks for @grimar 's suggestion
  - Add two helper functions: `shouldEmitDWARF()`, `emitDWARF()`.
  - Change the return type of `getUsedSectionNames()` to `SetVector<>`

[Test]

- Use precise check tags.
- Merge some testcases
- Add test for 'offset' property in (g) and (f).
- Add one test (h).
  - .debug_str is defined in the "Sections" entry, but with `SHT_DYNAMIC` tag.
- Add one test (i).
  - Only the "DWARF" entry exists. yaml2obj will not emit the .debug_str section.
- Use `llvm-readelf --hex-dump` to check the content of zeros.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80203/new/

https://reviews.llvm.org/D80203

Files:
  llvm/include/llvm/ObjectYAML/DWARFYAML.h
  llvm/include/llvm/ObjectYAML/ELFYAML.h
  llvm/lib/ObjectYAML/DWARFYAML.cpp
  llvm/lib/ObjectYAML/ELFEmitter.cpp
  llvm/lib/ObjectYAML/ELFYAML.cpp
  llvm/test/tools/yaml2obj/ELF/DWARF/debug-str.yaml

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D80203.265844.patch
Type: text/x-patch
Size: 14275 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200523/0d504651/attachment-0001.bin>