[PATCH] D19908: [X86] Support the "ms-hotpatch" attribute.

Fri May 22 14:30:24 PDT 2020

MaskRay added a subscriber: reames.
MaskRay added a comment.

In D19908#2051605 <https://reviews.llvm.org/D19908#2051605>, @aganea wrote:

> Hello! It seems this patch and another related patch <https://github.com/llvm/llvm-project/search?q=ms-hotpatch&type=Commits> were reverted and @cdavis5x has been inactive since.
>  Any objection if I tried to reland this? Is there a policy for abandonned patches?

I don't know the policy is written down anywhere. You may create a new patch and state that it is based on @cdavis5x.
I took a quick look at the test `llvm/test/CodeGen/X86/ms-hotpatch-attr.ll`. It can be improved a bit.

According to https://reviews.llvm.org/D72215#1815586 , @reames is a user of the existing "patchable-function" and you may need to add him as a reviewer.
("patchable-function-entry" and ("xray-instruction-threashold"|"function-instrument"="xray-always") are similar but different instrumentations.)

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D19908/new/

https://reviews.llvm.org/D19908