[PATCH] D80236: [VectorCombine] position pass after SLP in the optimization pipeline rather than before
Sanjay Patel via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri May 22 13:57:33 PDT 2020
spatel added a comment.
In D80236#2051460 <https://reviews.llvm.org/D80236#2051460>, @nikic wrote:
> This changes caused a 0.25% compile-time regression <http://llvm-compile-time-tracker.com/compare.php?from=22ed724975d265086149dcac8d2c983c1e49f13f&to=6438ea45e053378a3c461a879805174eaa864bdb&stat=instructions>. Looking at the pipeline test changes, this is probably because you do not preserve AAResultsWrapperPass inside VectorCombine.
Aha...thanks for pointing out the fix:
rG024098ae5349 <https://reviews.llvm.org/rG024098ae53497be2ddba82474451934611ce87d5>
There's still something wrong with alias analysis in the pipeline because that addsub test is getting folded in the old PM, but not the new PM.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D80236/new/
https://reviews.llvm.org/D80236
More information about the llvm-commits
mailing list