[PATCH] D80438: [LLD/MinGW]: Expose --thinlto-cache-dir

[Martin Storsjö via Phabricator via llvm-commits]

mstorsjo added a comment.

Looks great in general, a couple nitpicks



================
Comment at: lld/MinGW/Driver.cpp:352
+  for (auto *a : args.filtered(OPT_thinlto_cache_dir))
+    add("-lldltocache:" + StringRef(a->getValue()));
 
----------------
This option is the kind where you only have one (that's how the option is handled in COFF/Driver.cpp), so it's probably better to go with `getLastArg()` instead - you could place it next to e.g. `OPT_reproduce`.


================
Comment at: lld/MinGW/Options.td:86
+defm thinlto_cache_dir: Eq<"thinlto-cache-dir",
+  "Path to ThinLTO cached object file directory">;
+
----------------
Not sure if this really needs a section of its own - I'd put it below in LLD specific options.


================
Comment at: lld/test/MinGW/driver.test:247
+THINLTO_CACHEDIR: -lldltocache:_foo
\ No newline at end of file

----------------
Missing trailing newline


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80438/new/

https://reviews.llvm.org/D80438