[PATCH] D77589: libclc: Add Mesa/SPIR-V/DXIL target

Tom Stellard via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri May 22 10:10:47 PDT 2020


tstellar added inline comments.


================
Comment at: libclc/spirv-mesa3d-dxil/lib/subnormal_config.cl:1
 /*
- * Copyright (c) 2014,2015 Advanced Micro Devices, Inc.
----------------
daniels wrote:
> tstellar wrote:
> > What's going on with this file?  Is subnormal_config.cl a new file?
> It was copied and then just had its functionality decimated. I don't know what's going on with the copyright year, though. Should I just resubmit with the header reconciled?
So git tracked the copy?  I think it would be less confusing if you updated the patch, so that this is just a new file.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77589/new/

https://reviews.llvm.org/D77589





More information about the llvm-commits mailing list