[PATCH] D80311: [lld][test] Expand testing for dynamic-list and export-dynamic

[Owen Reynolds via Phabricator via llvm-commits]

gbreynoo marked 5 inline comments as done.
gbreynoo added inline comments.


================
Comment at: lld/test/ELF/dynamic-list-patterns.s:11
+# RUN: ld.lld -pie --dynamic-list %t.list %t.o -o %t.elf
+# RUN: llvm-readelf --dyn-symbols %t.elf | FileCheck %s
+
----------------
MaskRay wrote:
> `--dyn-syms`
> 
> You can also use `llvm-nm -D`
The other tests use llvm-readelf so thought it best to be consistent, also I think confirming the number of entries is easier with readelf.  If llvm-nm is preferred I could update the other tests too? 


================
Comment at: lld/test/ELF/export-symbol-types.s:32
+# RUN: llvm-readelf --dyn-symbols %t.elf | FileCheck %s
+# RUN: llvm-readelf --dyn-symbols %tlist.elf | FileCheck %s
+
----------------
MaskRay wrote:
> Can you find existing tests which can be deleted after you add the more comprehensive test here?
I had a look at the other tests for --dynamic-list and --export-dynamic and believe they each add coverage e.g. they test for a particular error message or are case when multiple symbols of the same type are exported together etc.  If there is a test you have in mind I could add it to the review.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80311/new/

https://reviews.llvm.org/D80311