[PATCH] D79283: [PowerPC] Add missing handling for half precision
Nemanja Ivanovic via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri May 22 05:51:28 PDT 2020
nemanjai marked an inline comment as done.
nemanjai added inline comments.
================
Comment at: llvm/test/CodeGen/PowerPC/handle-f16-storage-type.ll:202
declare i16 @llvm.convert.to.fp16.f32(float)
+define void @test_load_store(half* %in, half* %out) #0 {
+; P8-LABEL: test_load_store:
----------------
stefanp wrote:
> All of these functions are marked as `nounwind` (due to the `#0`) do they need to be marked as such?
In general, when using the script to generate the checks, I prefer to use `nounwind` so that we don't get all the `cfi` directives that don't really contribute to the test - just add clutter.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D79283/new/
https://reviews.llvm.org/D79283
More information about the llvm-commits
mailing list