[PATCH] D79963: [llvm][test] Add COM: directives before colon-less non-CHECKs in comments. NFC

Fri May 22 05:51:23 PDT 2020

jhenderson added a comment.

In D79963#2050833 <https://reviews.llvm.org/D79963#2050833>, @jroelofs wrote:

> In D79963#2050521 <https://reviews.llvm.org/D79963#2050521>, @jhenderson wrote:
>
> > In D79963#2049161 <https://reviews.llvm.org/D79963#2049161>, @jroelofs wrote:
> >
> > > 183d6af081899973f00fc24aeafcfc32de732f02 <https://reviews.llvm.org/rG183d6af081899973f00fc24aeafcfc32de732f02>
> >
> >
> > Why was this landed? There was varying degrees of dislike from more than one reviewer (myself, and @MaskRay at least). Please revert pending a conclusion to the discussion. This has hardly reached consensus.
>
>
> 5a8db275f8fc8ee19b184f831bda1cdfc6771776 <https://reviews.llvm.org/rG5a8db275f8fc8ee19b184f831bda1cdfc6771776>
>
> Sorry, misread the tone of the discussion as having been addressed by @jdenny & my follow-up comments.

No worries. Text is hard to communicate with! I think the discussion needs re-raising on llvm-dev, using this as an example of the consequence of the new FileCheck diagnostic.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79963/new/

https://reviews.llvm.org/D79963