[PATCH] D79854: [PowerPC] Prevent legalization loop from promoting SELECT_CC from v4i32 to v4i32

Stefan Pintilie via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri May 22 05:18:35 PDT 2020


stefanp accepted this revision as: stefanp.
stefanp added a comment.
This revision is now accepted and ready to land.

The name of the test is `pr45709` which refers to the bug number so I guess anyone interested should look there for the details.
However, I still agree with Amy that adding a description inside the test would be useful since the code in the test is not self explanatory.
Otherwise, LGTM.



================
Comment at: llvm/test/CodeGen/PowerPC/pr45709.ll:51
+
+; Function Attrs: nounwind readnone speculatable willreturn
+declare <4 x float> @llvm.maxnum.v4f32(<4 x float>, <4 x float>) #0
----------------
nit:
You can probably remove this comment if all we leave is `nounwind`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79854/new/

https://reviews.llvm.org/D79854





More information about the llvm-commits mailing list