[PATCH] D79695: [test][compiler-rt] Avoid LD_PRELOAD for "outer" dynamic linkers

Nemanja Ivanovic via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri May 22 03:36:31 PDT 2020


nemanjai accepted this revision.
nemanjai added a comment.
This revision is now accepted and ready to land.

So if I interpret this correctly, the existing behaviour will end up with something like `env LD_PRELOAD=<lib> env ASAN_OPTIONS=<opts> not ...`
which will run the inner `env` with `LD_PRELOAD` set. This patch flattens this to have only one invocation of `env` and sets both environment variables for the actual command.

I think this makes sense as long as `%env_asan_opts` does not end up expanding to something different on some platform (which I don't imagine is the case judging by the name).

LGTM.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79695/new/

https://reviews.llvm.org/D79695





More information about the llvm-commits mailing list