[PATCH] D80346: [llvm-extract] Fix basic block extraction by delaying search until the function is materialized

Volkan Keles via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu May 21 17:53:18 PDT 2020


volkan accepted this revision.
volkan added a comment.
This revision is now accepted and ready to land.

LGTM.



================
Comment at: llvm/tools/llvm-extract/llvm-extract.cpp:339
+      for (StringRef BBName : P.second) {
+        auto Res = llvm::find_if(*P.first, [&](const BasicBlock &BB) {
+          return BB.getName().equals(BBName);
----------------
It would be nice to have a comment here to explain why we verify the blocks here.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80346/new/

https://reviews.llvm.org/D80346





More information about the llvm-commits mailing list