[PATCH] D80358: [MLIR] Add OpTrait::DominanceFreeScope

[Chris Lattner via Phabricator via llvm-commits]

lattner accepted this revision.
lattner added a comment.

Please fix the lint warnings, but otherwise this LGTM as a step.  Thank you for driving this!

The primary problem with this patch is that it won't work with MLIR files that don't have registered ops.  To fix this, we need to either:

1. invert the polarity of the flag - making dominance checking "opt-in",  or
2. Have specific "verbose" syntax for unregistered ops that reflects this property, and a bit in `Operation` that tracks this (because the trait won't exist if the op isn't registered).

The discussion about the tradeoffs of these are involved, so we should probably do that async with landing this patch.

River do you agree?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80358/new/

https://reviews.llvm.org/D80358