[PATCH] D80361: [WebAssembly] Convert more lld and MC tests to assembly

Derek Schuff via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu May 21 12:59:51 PDT 2020


dschuff added inline comments.


================
Comment at: lld/test/wasm/optional-symbol.s:2
+# RUN: llvm-mc -filetype=obj -triple=wasm32-unknown-unknown -o %t.o %s
+# RUN: wasm-ld --export=get_handle %t.o -o %t.wasm
+
----------------
pre-exsting issue, but should this test have an expectation?


================
Comment at: lld/test/wasm/signature-mismatch.ll:79
 ; RELOC-NEXT:         Name:            call_ret32
-; RELOC-NEXT:         Flags:           [ VISIBILITY_HIDDEN ]
 ; RELOC-NEXT:         Function:        3
----------------
is this change in expectation intended?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80361/new/

https://reviews.llvm.org/D80361





More information about the llvm-commits mailing list