[PATCH] D80316: [HardwareLoops] Intrinsic LangRef descriptions

[Eli Friedman via Phabricator via llvm-commits]

efriedma added inline comments.


================
Comment at: llvm/docs/LangRef.rst:14945
+SCEV, so it's the backends responsibility to handle cases where it may be
+optimised, but are not allowed to duplicate these intrinsic calls.
+
----------------
"but are not allowed to duplicate these intrinsic calls"?  Run-on sentence, and I'm not sure what isn't allowed to duplicate the intrinsic calls.


================
Comment at: llvm/docs/LangRef.rst:14977
+counter and return false if the loop should exit, this ``SUB`` is not allowed
+to wrap.
+
----------------
Where does "llvm.loop.decrement" retrieve the loop iteration counter from?  I think we need to describe this a bit more carefully.  For the others, there's sort of a trivial lowering back to plain LLVM IR, but here I'm not sure what that looks like.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80316/new/

https://reviews.llvm.org/D80316