[PATCH] D80393: [mlir][Vector] Add more vector.contract -> outerproduct lowerings and fix vector.contract type inference.

[Nicolas Vasilache via Phabricator via llvm-commits]

nicolasvasilache created this revision.
nicolasvasilache added reviewers: aartbik, andydavis1, ftynse.
Herald added subscribers: llvm-commits, jurahul, Kayjukh, frgossen, grosul1, Joonsoo, stephenneuendorffer, liufengdb, lucyrfox, mgester, arpith-jacob, antiagainst, shauheen, jpienaar, rriddle, mehdi_amini.
Herald added a project: LLVM.

This revision expands the types of vector contractions that can be lowered to vector.outerproduct.
All 8 permutation cases are support.
The idiomatic manipulation of AffineMap written declaratively makes this straightforward.

In the process a bug with the vector.contract verifier was uncovered.
The vector shape verification part of the contract op is rewritten to use AffineMap composition.
One bug in the vector `ops.mlir` test is fixed and a new case not yet captured is added
to the vector`invalid.mlir` test.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D80393

Files:
  mlir/lib/Dialect/Vector/VectorOps.cpp
  mlir/lib/Dialect/Vector/VectorTransforms.cpp
  mlir/test/Dialect/Vector/invalid.mlir
  mlir/test/Dialect/Vector/ops.mlir
  mlir/test/Dialect/Vector/vector-contract-transforms.mlir

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D80393.265553.patch
Type: text/x-patch
Size: 25036 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200521/05909346/attachment-0001.bin>