[PATCH] D79959: [SampleFDO] Add use-sample-profile function attribute

Thu May 21 11:21:56 PDT 2020

wenlei accepted this revision.
wenlei added a comment.
This revision is now accepted and ready to land.

In D79959#2047325 <https://reviews.llvm.org/D79959#2047325>, @wmi wrote:

> In D79959#2047294 <https://reviews.llvm.org/D79959#2047294>, @wenlei wrote:
>
> > I guess you accidentally missed InlineCost.cpp in latest version?
>
>
> I don't need to change InlineCost.cpp. Adding "def : CompatRule<"isEqual<UseSampleProfileAttr>">" in include/llvm/IR/Attributes.td will automatically update the function hasCompatibleFnAttrs auto-generated. hasCompatibleFnAttrs is indirectly called by functionsHaveCompatibleAttributes and getInlineCost.

Ah, thanks for clarifying! LGTM.

Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79959/new/

https://reviews.llvm.org/D79959