[PATCH] D80338: [AMDGPU] GFX10 PAL: Only pad with s_code_end in pipeline compilation

Stanislav Mekhanoshin via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu May 21 09:09:08 PDT 2020


rampitec added inline comments.


================
Comment at: llvm/test/CodeGen/AMDGPU/s_code_end_pal_pipeline.ll:10
 
-define amdgpu_kernel void @a_kernel1() {
+define amdgpu_vs void @a_kernel1() {
   ret void
----------------
tpr wrote:
> rampitec wrote:
> > Can you create a separate test instead?
> This file s_code_end_pal_pipeline.ll is a new separate test. arc diff got confused in the way it constructed the diff -- I modified the original s_code_end.ll to expect PAL to not do padding, and added this new s_code_end_pal_pipeline.ll to check that it does add padding for a PAL pipeline.
Ah, indeed. Very confusing.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80338/new/

https://reviews.llvm.org/D80338





More information about the llvm-commits mailing list