[PATCH] D79745: [YAMLTraits] Add trait for char

[Rainer Orth via Phabricator via llvm-commits]

ro added a comment.

Given the Solaris buildbots had been broken for a week and a half, I had reverted the patch.

Unfortunately, this breaks the lldb-x86_64-debian buildbot:

  FAILED: tools/lldb/source/Utility/CMakeFiles/lldbUtility.dir/Args.cpp.o 
  /usr/bin/clang++  -DGTEST_HAS_RTTI=0 -DHAVE_ROUND -DLLDB_CONFIGURATION_RELEASE -D_DEBUG -D_GNU_SOURCE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -Itools/lldb/source/Utility -I/home/worker/lldb-x86_64-debian/lldb-x86_64-debian/llvm-project/lldb/source/Utility -Itools/lldb/source -I/home/worker/lldb-x86_64-debian/lldb-x86_64-debian/llvm-project/lldb/include -Itools/lldb/include -Iinclude -I/home/worker/lldb-x86_64-debian/lldb-x86_64-debian/llvm-project/llvm/include -I/usr/include/python3.7m -I/home/worker/lldb-x86_64-debian/lldb-x86_64-debian/llvm-project/llvm/../clang/include -Itools/lldb/../clang/include -I/home/worker/lldb-x86_64-debian/lldb-x86_64-debian/llvm-project/lldb/source/. -fPIC -fvisibility-inlines-hidden -Werror=date-time -Werror=unguarded-availability-new -Wall -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wmissing-field-initializers -pedantic -Wno-long-long -Wimplicit-fallthrough -Wcovered-switch-default -Wno-noexcept-type -Wnon-virtual-dtor -Wdelete-non-virtual-dtor -Wstring-conversion -fdiagnostics-color -ffunction-sections -fdata-sections -Wno-deprecated-declarations -Wno-unknown-pragmas -Wno-strict-aliasing -Wno-deprecated-register -Wno-vla-extension -O3     -fno-exceptions -fno-rtti -UNDEBUG -std=c++14 -MD -MT tools/lldb/source/Utility/CMakeFiles/lldbUtility.dir/Args.cpp.o -MF tools/lldb/source/Utility/CMakeFiles/lldbUtility.dir/Args.cpp.o.d -o tools/lldb/source/Utility/CMakeFiles/lldbUtility.dir/Args.cpp.o -c /home/worker/lldb-x86_64-debian/lldb-x86_64-debian/llvm-project/lldb/source/Utility/Args.cpp
  In file included from /home/worker/lldb-x86_64-debian/lldb-x86_64-debian/llvm-project/lldb/source/Utility/Args.cpp:9:
  In file included from /home/worker/lldb-x86_64-debian/lldb-x86_64-debian/llvm-project/lldb/include/lldb/Utility/Args.h:17:
  /home/worker/lldb-x86_64-debian/lldb-x86_64-debian/llvm-project/llvm/include/llvm/Support/YAMLTraits.h:1123:36: error: implicit instantiation of undefined template 'llvm::yaml::MissingTrait<char>'
    char missing_yaml_trait_for_type[sizeof(MissingTrait<T>)];
                                     ^
  /home/worker/lldb-x86_64-debian/lldb-x86_64-debian/llvm-project/llvm/include/llvm/Support/YAMLTraits.h:945:7: note: in instantiation of function template specialization 'llvm::yaml::yamlize<char>' requested here
        yamlize(*this, Val, Required, Ctx);
        ^
  /home/worker/lldb-x86_64-debian/lldb-x86_64-debian/llvm-project/llvm/include/llvm/Support/YAMLTraits.h:851:11: note: in instantiation of function template specialization 'llvm::yaml::IO::processKey<char, llvm::yaml::EmptyContext>' requested here
      this->processKey(Key, Val, true, Ctx);
            ^
  /home/worker/lldb-x86_64-debian/lldb-x86_64-debian/llvm-project/lldb/source/Utility/Args.cpp:692:6: note: in instantiation of function template specialization 'llvm::yaml::IO::mapRequired<char>' requested here
    io.mapRequired("quote", keys->quote);
       ^
  /home/worker/lldb-x86_64-debian/lldb-x86_64-debian/llvm-project/llvm/include/llvm/Support/YAMLTraits.h:307:8: note: template is declared here
  struct MissingTrait;
         ^
  1 error generated.

Any suggestions on how to move forward from here?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79745/new/

https://reviews.llvm.org/D79745