[PATCH] D78500: [DWARF5]:Added support for .debug_macro.dwo section in llvm-dwarfdump

[Igor Kudrin via Phabricator via llvm-commits]

ikudrin added a comment.

I am still not really contented that there are two distinct methods to get strings from a string section in `DWARFDebugMacro::parseImpl()`, one for `_strp` codes and another for `_strx`. Is there a way to unify them?



================
Comment at: llvm/test/DebugInfo/X86/debug-macro-strx-dwo.s:49
+	.long	.Ldebug_info_dwo_end0-.Ldebug_info_dwo_start0 # Length of Unit
+
+.Ldebug_info_dwo_start0:
----------------
Remove this empty line.


================
Comment at: llvm/test/DebugInfo/X86/debug-macro-strx-dwo.s:60
+.Ldebug_info_dwo_end0:
+	.section	.debug_abbrev.dwo,"e", at progbits
+	.byte	1                       # Abbreviation Code
----------------
Add an empty line before `.section`.


================
Comment at: llvm/test/DebugInfo/X86/debug-macro-strx-dwo.s:63
+	.byte	17                      # DW_TAG_compile_unit
+	.byte	1                       # DW_CHILDREN_yes
+	.byte	121                     # DW_AT_macros
----------------
In fact, this DIE does not have any children.


================
Comment at: llvm/test/DebugInfo/X86/debug-macro-strx-dwo.s:67
+	.byte	0                       # EOM(1)
+	.byte	0                       # EOM(2)
----------------
There should be yet another zero byte which terminates the abbreviation table for the CU.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78500/new/

https://reviews.llvm.org/D78500