[PATCH] D80203: [ObjectYAML][DWARF] Add DWARF entry in ELFYAML.

James Henderson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu May 21 01:36:17 PDT 2020


jhenderson added inline comments.


================
Comment at: llvm/lib/ObjectYAML/ELFEmitter.cpp:761
+  } else
+    reportError("the content of the " + Name + " section should be specified");
+
----------------
jhenderson wrote:
> Maybe this can just result in an empty section rather than an error?
In fact, looking at the test cases that are still failing, I think that's exactly what we need to do. Since you zero the section header, you probably can just delete this `else`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80203/new/

https://reviews.llvm.org/D80203





More information about the llvm-commits mailing list