[PATCH] D80343: [mlir][gpu] Fix CMake errors in case NVPTX is not enabled. NFC.

Wen-Heng (Jack) Chung via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed May 20 22:01:53 PDT 2020


whchung added a subscriber: rsmith.
whchung added a comment.

In D80343#2048267 <https://reviews.llvm.org/D80343#2048267>, @mehdi_amini wrote:

> I only see this now, I already reverted the offending patch I think. In the future if you have a fix for a build failure, please land it directly without code review: it is more important to unbreak everyone ASAP (either through revert or hot fix). 
>  You can always ping the original revision to indicate that you had to do that so that the original reviewer can take a look at it post-review.
>
> Right now the best course of action is to squash this into your original patch and land it back (there is a comment from Richard in your original revision that should likely be addressed first).


@mehdi_amini Sorry for causing the confusions. Will follow the guidance in the future. I've reopened D80167 <https://reviews.llvm.org/D80167> and addressed comments from @rsmith and you.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80343/new/

https://reviews.llvm.org/D80343





More information about the llvm-commits mailing list