[PATCH] D80227: Fix FindZ3.cmake to work with static Z3 libraries

Artem Dinaburg via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed May 20 22:01:49 PDT 2020


ArtemDinaburg added a comment.

In D80227#2047567 <https://reviews.llvm.org/D80227#2047567>, @ddcc wrote:

> I'm not entirely convinced that it's a race, but a separate file seems fine. Have you tested with e.g. LLVM_OPTIMIZED_TABLEGEN? It might be safer to use LLVM_MAIN_SRC_DIR instead of CMAKE_SOURCE_DIR.
>
> Looks fine to me, but might be best to get someone else to take a look as well.


Hi Dominic,

I wasn't sure either; I asked on the CMake Developer forums and the answer was that a race was not possible. My issue was certainly real Maybe the write was failing for some unrelated reason.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80227/new/

https://reviews.llvm.org/D80227





More information about the llvm-commits mailing list