[PATCH] D80167: [mlir][gpu] Refactor ConvertGpuLaunchFuncToCudaCalls pass.

Richard Smith - zygoloid via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed May 20 19:21:00 PDT 2020


rsmith added inline comments.


================
Comment at: mlir/tools/mlir-cuda-runner/cuda-runtime-wrappers.cpp:40
 
 extern "C" int32_t mcuModuleGetFunction(void **function, void *module,
                                         const char *name) {
----------------
I'm seeing test failures caused by undefined references to `mgpuModuleGetFunction`. Did you intend to rename this function too?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80167/new/

https://reviews.llvm.org/D80167





More information about the llvm-commits mailing list