[PATCH] D80326: [SVE] Eliminate calls to default-false VectorType::get() from Linker

Christopher Tetreault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed May 20 17:08:45 PDT 2020


ctetreau marked an inline comment as done.
ctetreau added inline comments.


================
Comment at: llvm/lib/Linker/IRMover.cpp:312
+    return *Entry = FixedVectorType::get(
+               ElementTypes[0], cast<VectorType>(Ty)->getNumElements());
   case Type::PointerTyID:
----------------
efriedma wrote:
> While you're here, please change the `cast<>` to `cast<FixedVectorType>(Ty)`.
I actually skipped that on purpose to keep the patch small. Knowing my luck, this would cause a test failure.

I can make the change.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80326/new/

https://reviews.llvm.org/D80326





More information about the llvm-commits mailing list