[PATCH] D74755: [llvm-objcopy] Attribute an empty section to a segment ending at its address
Fangrui Song via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed May 20 17:08:03 PDT 2020
MaskRay added a comment.
So, is `uint64_t SecSize = Sec.Size ? Sec.Size : 1;` a subtle condition we may want to get rid of? Or is simplifying code can still be problematic? IMHO there are a few points regarding hypothetical use cases but: (1) they don't appear to be used (2) their reliance on the current behavior does not have a solid guarantee.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D74755/new/
https://reviews.llvm.org/D74755
More information about the llvm-commits
mailing list