[PATCH] D80302: [mlir] Canonicalization of shape.assuming

[Jacques Pienaar via Phabricator via llvm-commits]

jpienaar accepted this revision.
jpienaar added inline comments.
This revision is now accepted and ready to land.


================
Comment at: mlir/lib/Dialect/Shape/IR/Shape.cpp:174
+                                PatternRewriter &rewriter) const override {
+    if (op.witness().getDefiningOp<TrueWitnessOp>()) {
+      auto *firstBlock = rewriter.getInsertionBlock();
----------------
Early return?


================
Comment at: mlir/lib/Dialect/Shape/IR/Shape.cpp:176
+      auto *firstBlock = rewriter.getInsertionBlock();
+      auto *secondBlock = op.getBody();
+      auto initPosition = rewriter.getInsertionPoint();
----------------
Is there perhaps more descriptive names we could use here?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80302/new/

https://reviews.llvm.org/D80302