[PATCH] D80281: [MLIR] Add `num_elements` to the shape dialect

[Jacques Pienaar via Phabricator via llvm-commits]

jpienaar accepted this revision.
jpienaar added a comment.
This revision is now accepted and ready to land.

Thanks



================
Comment at: mlir/include/mlir/Dialect/Shape/IR/ShapeOps.td:242
+    dimensions.
+    A tensor of the given shape will hold this many elements.
+    Expects a `shape.shape` and returns a `shape.size` value.
----------------
Seems redundant with the previous line?


================
Comment at: mlir/include/mlir/Dialect/Shape/IR/ShapeOps.td:243
+    A tensor of the given shape will hold this many elements.
+    Expects a `shape.shape` and returns a `shape.size` value.
+  }];
----------------
Already documented in arguments and results


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80281/new/

https://reviews.llvm.org/D80281