[PATCH] D80320: [AARCH64][NEON] Allow to sink operands of aarch64_neon_pmull64.

Dave Green via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed May 20 16:33:49 PDT 2020


dmgreen added inline comments.


================
Comment at: llvm/lib/Target/AArch64/AArch64ISelLowering.cpp:9407
+
+  if (ConstantInt *CI = dyn_cast<ConstantInt>(ExtInstr->getIndexOperand()))
+    if (CI->getZExtValue() != 1)
----------------
This wouldn't return false on non-constant operands either. (Not that I would expect that to come up much!)

You might find that the m_ExtractElement style pattern matchers make this simpler to handle.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80320/new/

https://reviews.llvm.org/D80320





More information about the llvm-commits mailing list