[PATCH] D80307: [mlir] Add a shape op that always returns a successful witness

[Sean Silva via Phabricator via llvm-commits]

silvas accepted this revision.
silvas added a comment.

LGTM, thanks :)

See my comment in the other patch about using this in ShapeDialect::materializeConstant

(I'm on the fence about having a `const_witness {true,false}` vs true_witness/false_witness ops; that latter is a bit easier to match with isa<TrueWitnessOp> so I tend to lean towards it, but the former is more consistent with const_shape/const_size and maybe a simple helper can recuperate the advantages of isa<TrueWitnessOp>'s simplicity; feel free to choose whatever makes sense)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80307/new/

https://reviews.llvm.org/D80307