[PATCH] D80305: [mlir] Add folding for shape.any
Sean Silva via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed May 20 12:02:47 PDT 2020
silvas accepted this revision.
silvas added inline comments.
================
Comment at: mlir/test/Dialect/Shape/canonicalize.mlir:154
+// -----
+// any is not yet replaced without a constant input.
+// CHECK-LABEL: func @f
----------------
Can you expand a bit on this "yet"? Is that a direction we want to go? It seems like it would be a very small change to this patch to support that, suggesting there is a deeper reason why we want to avoid that, which would be good to document here or in AnyOp::fold
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D80305/new/
https://reviews.llvm.org/D80305
More information about the llvm-commits
mailing list