[PATCH] D79112: [SelectionDAG] Add the option of disabling generic combines.

[Marcello Maggioni via Phabricator via llvm-commits]

kariddi added inline comments.


================
Comment at: llvm/include/llvm/CodeGen/SelectionDAGTargetInfo.h:164-165
+
+  // Return true if the Machine Combiner should disable generic combines.
+  virtual bool disableGenericCombines(CodeGenOpt::Level OptLevel) const {
+    return false;
----------------
arsenm wrote:
> This isn't a machine combiner, also should specify DAG combiner?
I used the same naming other functions (used in DAG combiner) , but I agree is kind of a weird naming honestly, considering the GlobalISel effort (probably the previous naming was pre-GISel itself). I'll change the comment to explicitly mention the DAG combiner.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79112/new/

https://reviews.llvm.org/D79112