[PATCH] D80248: Added pow intrinsic to LLVMIR dialect

[George Mitenkov via Phabricator via llvm-commits]

georgemitenkov updated this revision to Diff 265264.
georgemitenkov marked 3 inline comments as done.
georgemitenkov added a comment.

Added a test for conversion to LLVM proper

Added a pow intrinsic test to Target/llvmir-intrinsic.mlir. Changed pow call in roundtrip test to take %arg1 as arguments.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80248/new/

https://reviews.llvm.org/D80248

Files:
  mlir/test/Dialect/LLVMIR/roundtrip.mlir
  mlir/test/Target/llvmir-intrinsics.mlir


Index: mlir/test/Target/llvmir-intrinsics.mlir
===================================================================
--- mlir/test/Target/llvmir-intrinsics.mlir
+++ mlir/test/Target/llvmir-intrinsics.mlir
@@ -108,6 +108,15 @@
   llvm.return
 }
 
+// CHECK-LABEL: @pow_test
+llvm.func @pow_test(%arg0: !llvm.float, %arg1: !llvm.float, %arg2: !llvm<"<8 x float>">, %arg3: !llvm<"<8 x float>">) {
+  // CHECK: call float @llvm.pow.f32
+  "llvm.intr.pow"(%arg0, %arg1) : (!llvm.float, !llvm.float) -> !llvm.float
+  // CHECK: call <8 x float> @llvm.pow.v8f32
+  "llvm.intr.pow"(%arg2, %arg3) : (!llvm<"<8 x float>">, !llvm<"<8 x float>">) -> !llvm<"<8 x float>">
+  llvm.return
+}
+
 // CHECK-LABEL: @vector_reductions
 llvm.func @vector_reductions(%arg0: !llvm.float, %arg1: !llvm<"<8 x float>">, %arg2: !llvm<"<8 x i32>">) {
   // CHECK: call i32 @llvm.experimental.vector.reduce.add.v8i32
Index: mlir/test/Dialect/LLVMIR/roundtrip.mlir
===================================================================
--- mlir/test/Dialect/LLVMIR/roundtrip.mlir
+++ mlir/test/Dialect/LLVMIR/roundtrip.mlir
@@ -100,10 +100,8 @@
 // CHECK: "llvm.intr.sin"(%arg1) : (!llvm.float) -> !llvm.float
   %30 = "llvm.intr.sin"(%arg1) : (!llvm.float) -> !llvm.float
 
-// CHECK:       %31 = llvm.mlir.constant(4.200000e+00 : f32) : !llvm.float
-// CHECK-NEXT:  %32 = "llvm.intr.pow"(%arg1, %31) : (!llvm.float, !llvm.float) -> !llvm.float
-  %31 = llvm.mlir.constant(4.200000e+00 : f32) : !llvm.float
-  %32 = "llvm.intr.pow"(%arg1, %31) : (!llvm.float, !llvm.float) -> !llvm.float
+// CHECK: "llvm.intr.pow"(%arg1, %arg1) : (!llvm.float, !llvm.float) -> !llvm.float
+  %31 = "llvm.intr.pow"(%arg1, %arg1) : (!llvm.float, !llvm.float) -> !llvm.float
 
 // CHECK:  llvm.return
   llvm.return


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D80248.265264.patch
Type: text/x-patch
Size: 1763 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200520/1b4c8e62/attachment.bin>