[PATCH] D79838: [mlir][Linalg] Add producer-consumer fusion when producer is a ConstantOp and Consumer is a GenericOp.
Nicolas Vasilache via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed May 20 08:11:02 PDT 2020
nicolasvasilache added a comment.
`I dont think this is related to tied input/output tensors. I might be missing something here, but the tied input/output tensor is for initialization sorts of things (a symptom of such a thing is when one of the iterator types is "reduction"). There are cases I have seen in IREE where some operands to pointwise-add are splat constants (I dont know why that is the case though in the input though, havent dug into it)`
The point is that one would translate ConstantOp to Linalg generic beforehand and not introduce op-dependent special-casing in fusion.
Special casing in transformations is what we want to avoid at all costs.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D79838/new/
https://reviews.llvm.org/D79838
More information about the llvm-commits
mailing list